dkanus/Avarice
2
1
Fork 1
Code Issues 9 Pull Requests 2 Releases Wiki Activity

Add network link to ue-server implementation #13

Open
dkanus wants to merge 23 commits from feature_link into master
pull from: feature_link
merge into: dkanus:master
Conversation 6 Commits 23 Files Changed 8 +5 -1
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 0dedd1d1f1 - Show all commits

6
src/link/mod.rs
View File

@ -20,6 +20,9 @@ const HEAD_UE_MESSAGE: u8 = 42;
// Maximum allowed size of JSON message sent from ue-server.
const MAX_UE_MESSAGE_LENGTH: usize = 25 * 1024 * 1024;
// We do not expect to receive more that this much messages at once from ue-server
const EXPECTED_LIMIT_TO_UE_MESSAGES: usize = 100;
dkanus marked this conversation as resolved Outdated
Ggg_123 commented 2021-07-22 20:09:46 +03:00
Outdated
Review
Copy Link

with_capacity != limit.
Should it really be a constant?
I'd just inline it.

with_capacity != limit. Should it really be a constant? I'd just inline it.
dkanus commented 2021-07-22 21:52:31 +03:00
Outdated
Review
Copy Link

It is expected limit that we use as a capacity.

It is expected limit that we use as a capacity.
dkanus commented 2021-07-22 21:56:42 +03:00
Outdated
Review
Copy Link

But upon further consideration I agree that there is no sense in defining this as a constant.

But upon further consideration I agree that there is no sense in defining this as a constant.
custom_error! { pub ReadingStreamError
Ggg_123 commented 2021-07-24 09:11:09 +03:00
Outdated
Review
Copy Link

Can be simplified => // Listen to new connections

Can be simplified => // Listen to new connections
InvalidHead{input: u8} = "Invalid byte used as a HEAD: {input}",
Ggg_123 marked this conversation as resolved
Ggg_123 commented 2021-07-24 09:19:45 +03:00
Review
Copy Link

Probably needs a timeout, to avoid waiting forever:
stream
.set_read_timeout(Some(Duration::from_secs(5)))
.unwrap();

Probably needs a timeout, to avoid waiting forever: stream .set_read_timeout(Some(Duration::from_secs(5))) .unwrap();
MessageTooLong{length: usize} = "Message to receive is too long: {length}",
@ -63,8 +66,9 @@ impl MessageReader {
reading_state: ReadingState::Head,
read_bytes: 0,
current_message_length: 0,
// Will be recreated with `with_capacity` in `push_byte()`
Ggg_123 commented 2021-08-07 12:57:18 +03:00
Review
Copy Link

Why?

Why?
current_message: Vec::new(),
read_messages: VecDeque::new(),
read_messages: VecDeque::with_capacity(EXPECTED_LIMIT_TO_UE_MESSAGES),
next_received_bytes: 0,
received_bytes: 0,
}