dkanus/Avarice
2
1
Fork 1
Code Issues 9 Pull Requests 2 Releases Wiki Activity

Add network link to ue-server implementation #13

Open
dkanus wants to merge 23 commits from feature_link into master
pull from: feature_link
merge into: dkanus:master
Conversation 6 Commits 23 Files Changed 8 +3 -5
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 202fa39a42 - Show all commits

8
src/link/mod.rs
View File

@ -10,12 +10,10 @@ const UE_RECEIVED_FIELD_SIZE: usize = 4;
// Defines how many bytes is used to encode "LENGTH" field, describing length of
dkanus marked this conversation as resolved Outdated
Ggg_123 commented 2021-07-21 08:57:21 +03:00
Outdated
Review
Copy Link

Wtf

Wtf
// next JSON message from ue-server
dkanus marked this conversation as resolved Outdated
Ggg_123 commented 2021-07-21 08:57:25 +03:00
Outdated
Review
Copy Link

Wtf

Wtf
const UE_LENGTH_FIELD_SIZE: usize = 4;
// Value indicating that next byte sequence from ue-server reports amount of bytes received by
// that server so far. Value itself is arbitrary.
// Arbitrary value indicating that next byte sequence from ue-server reports amount of bytes
// received by that server so far.
dkanus marked this conversation as resolved Outdated
Ggg_123 commented 2021-07-22 20:10:38 +03:00
Outdated
Review
Copy Link

Remove " Value itself is arbitrary", change to "Arbitrary value indicating that ..."?

Remove " Value itself is arbitrary", change to "Arbitrary value indicating that ..."?
const HEAD_UE_RECEIVED: u8 = 85;
dkanus marked this conversation as resolved Outdated
Ggg_123 commented 2021-07-22 20:20:55 +03:00
Outdated
Review
Copy Link

Weird empty line

Weird empty line
// Value indicating that next byte sequence from ue-server contains JSON message.
// Value itself is arbitrary.
// Arbitrary value indicating that next byte sequence from ue-server contains JSON message.
const HEAD_UE_MESSAGE: u8 = 42;
// Maximum allowed size of JSON message sent from ue-server.
const MAX_UE_MESSAGE_LENGTH: usize = 25 * 1024 * 1024;