dkanus/Avarice
2
1
Fork 1
Code Issues 9 Pull Requests 2 Releases Wiki Activity

Add network link to ue-server implementation #13

Open
dkanus wants to merge 23 commits from feature_link into master
pull from: feature_link
merge into: dkanus:master
Conversation 6 Commits 23 Files Changed 8 +8 -8
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 9ca00c5b8c - Show all commits

16
src/link/mod.rs
View File

@ -203,19 +203,19 @@ fn received_push_byte() {
reader.push_byte(0).unwrap(); reader.push_byte(0).unwrap();
reader.push_byte(0).unwrap(); reader.push_byte(0).unwrap();
reader.push_byte(0).unwrap(); reader.push_byte(0).unwrap();
reader.push_byte(243).unwrap(); reader.push_byte(0xf3).unwrap();
assert_eq!(reader.ue_received_bytes(), 243); assert_eq!(reader.ue_received_bytes(), 0xf3);
reader.push_byte(HEAD_UE_RECEIVED).unwrap(); reader.push_byte(HEAD_UE_RECEIVED).unwrap();
reader.push_byte(65).unwrap(); reader.push_byte(0x41).unwrap();
reader.push_byte(25).unwrap(); reader.push_byte(0x19).unwrap();
reader.push_byte(178).unwrap(); reader.push_byte(0xb2).unwrap();
reader.push_byte(4).unwrap(); reader.push_byte(0x04).unwrap();
assert_eq!(reader.ue_received_bytes(), 1092203255); assert_eq!(reader.ue_received_bytes(), 0x41_19_b2_f7); // 0xf7 = 0x04 + 0xf3
reader.push_byte(HEAD_UE_RECEIVED).unwrap(); reader.push_byte(HEAD_UE_RECEIVED).unwrap();
reader.push_byte(231).unwrap(); reader.push_byte(231).unwrap();
dkanus marked this conversation as resolved Outdated
Ggg_123 commented 2021-07-22 20:13:25 +03:00
Outdated
Review
Copy Link

Replace with:
reader.push_byte(0xf3).unwrap();
...
reader.push_byte(0x41).unwrap();
reader.push_byte(0x19).unwrap();
reader.push_byte(0xb2).unwrap();
reader.push_byte(0x04).unwrap();
assert_eq!(reader.ue_received_bytes(), 0x41_19_b2_f7); // 0xf7 = 0x04 + 0xf3
Because otherwise this is "magic numbers wtf".

Replace with: reader.push_byte(0xf3).unwrap(); ... reader.push_byte(0x41).unwrap(); reader.push_byte(0x19).unwrap(); reader.push_byte(0xb2).unwrap(); reader.push_byte(0x04).unwrap(); assert_eq!(reader.ue_received_bytes(), 0x41_19_b2_f7); // 0xf7 = 0x04 + 0xf3 Because otherwise this is "magic numbers wtf".
dkanus commented 2021-07-22 21:27:40 +03:00
Outdated
Review
Copy Link

Woa, that's neat. Agreed.

Woa, that's neat. Agreed.
reader.push_byte(34).unwrap(); reader.push_byte(34).unwrap();
reader.push_byte(154).unwrap(); reader.push_byte(154).unwrap();
assert_eq!(reader.ue_received_bytes(), 1092203255); assert_eq!(reader.ue_received_bytes(), 0x41_19_b2_f7);
} }
#[test] #[test]