dkanus/Avarice
2
1
Fork 1
Code Issues 9 Pull Requests 2 Releases Wiki Activity

Add network link to ue-server implementation #13

Open
dkanus wants to merge 23 commits from feature_link into master
pull from: feature_link
merge into: dkanus:master
Conversation 6 Commits 23 Files Changed 8 +6 -6
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit f118767e3f - Show all commits

12
src/link/mod.rs
View File

@ -39,7 +39,7 @@ pub struct MessageReader {
is_broken: bool,
reading_state: ReadingState,
read_bytes: usize,
buffer: [u8; 4],
length_buffer: [u8; 4],
current_message_length: usize,
current_message: Vec<u8>,
read_messages: VecDeque<String>,
@ -63,7 +63,7 @@ impl MessageReader {
is_broken: false,
Ggg_123 commented 2021-08-07 12:57:06 +03:00
Review
Copy Link

Missing else? Condition seems important.

Missing else? Condition seems important.
reading_state: ReadingState::Head,
read_bytes: 0,
buffer: [0; 4],
length_buffer: [0; 4],
current_message_length: 0,
// Will be recreated with `with_capacity` in `push_byte()`
current_message: Vec::new(),
Ggg_123 commented 2021-08-07 12:57:18 +03:00
Review
Copy Link

Why?

Why?
@ -88,18 +88,18 @@ impl MessageReader {
}
}
ReadingState::ReceivedBytes => {
self.buffer[self.read_bytes] = input;
self.length_buffer[self.read_bytes] = input;
Ggg_123 commented 2021-08-07 13:03:47 +03:00
Review
Copy Link

Why is it a separate function, and not inside send/flush?
When should I call it?

Why is it a separate function, and not inside send/flush? When should I call it?
self.read_bytes += 1;
if self.read_bytes >= UE_RECEIVED_FIELD_SIZE {
self.ue_received_bytes += array_of_u8_to_u32(self.buffer) as u64;
self.ue_received_bytes += array_of_u8_to_u32(self.length_buffer) as u64;
self.change_state(ReadingState::Head);
}
}
ReadingState::Length => {
self.buffer[self.read_bytes] = input;
self.length_buffer[self.read_bytes] = input;
self.read_bytes += 1;
if self.read_bytes >= UE_LENGTH_FIELD_SIZE {
self.current_message_length = array_of_u8_to_u32(self.buffer) as usize;
self.current_message_length = array_of_u8_to_u32(self.length_buffer) as usize;
self.change_state(ReadingState::Payload);
Ggg_123 commented 2021-08-07 13:05:14 +03:00
Review
Copy Link

// todo - add IP support, since 0.0.0.0 is subjective (make it default, but changeable)

// todo - add IP support, since 0.0.0.0 is subjective (make it default, but changeable)
if self.current_message_length > MAX_UE_MESSAGE_LENGTH {
self.is_broken = true;