• Joined on 2020-07-03
dkanus commented on pull request dkanus/Avarice#13 2021-07-29 13:45:46 +03:00
Add network link to ue-server implementation

Changed in upcoming patch.

dkanus commented on pull request dkanus/Avarice#13 2021-07-29 13:45:31 +03:00
Add network link to ue-server implementation

Fixed in upcoming patch.

dkanus commented on pull request dkanus/Avarice#13 2021-07-29 13:45:17 +03:00
Add network link to ue-server implementation

Changed in upcoming patch.

dkanus commented on pull request dkanus/Avarice#13 2021-07-29 13:44:55 +03:00
Add network link to ue-server implementation

Changed in upcoming patch.

dkanus commented on pull request dkanus/Avarice#13 2021-07-24 11:26:11 +03:00
Add network link to ue-server implementation

self.sent_bytes and self.ue_received_bytes are u64 and usize can be u32. In case we have fucked up - difference between them can get huge, this accounts for that.

I don't actually think…

dkanus commented on pull request dkanus/Avarice#13 2021-07-24 11:20:39 +03:00
Add network link to ue-server implementation

It passes to MessageWriter the whole amount of bytes passed so far, not just after the last update. This way it's harder to mess up.

dkanus commented on pull request dkanus/Avarice#13 2021-07-24 11:15:27 +03:00
Add network link to ue-server implementation

4096 is limitation on how much we can write, it's unrelated to reading and this is an arbitrary constant. Honestly I don't know what to use, but one option is to add BufReader and read byte-by-byte.

dkanus commented on pull request dkanus/Avarice#13 2021-07-24 01:10:52 +03:00
Add network link to ue-server implementation

MessageWriter is now a proper implementation.

Also have added Link implementation that:

  1. Trying to listen to a port and spawns a new handler thread for every connection;
  2. Currently…
dkanus pushed to feature_link at dkanus/Avarice 2021-07-24 00:48:03 +03:00
26b7d1dd91 Add network prototype
65ef791f00 Fix clippy warnings
034b7860d6 Refactor MessageWriter
Compare 3 commits »
dkanus pushed to feature_link at dkanus/Avarice 2021-07-23 01:54:43 +03:00
5bfdd61248 Add MessageWriter implementation
f310febe62 Add new mod.rs file with for link module
816454f4cf Move MessageReader into a separate file
Compare 3 commits »
dkanus pushed to feature_link at dkanus/Avarice 2021-07-22 22:02:52 +03:00
b187041d9e Move documentation for MessageReader
3f660f54d5 Remove EXPECTED_LIMIT_TO_UE_MESSAGES constant
5ce511c5a7 Refactor main.rs to use if let construction
978a5c4182 Change UE_RECEIVED_FIELD_SIZE to 2
e3f554218a Refactor push_byte's code
Compare 8 commits »
dkanus commented on pull request dkanus/Avarice#13 2021-07-22 21:56:42 +03:00
Add network link to ue-server implementation

But upon further consideration I agree that there is no sense in defining this as a constant.

dkanus commented on pull request dkanus/Avarice#13 2021-07-22 21:55:52 +03:00
Add network link to ue-server implementation

In general I am against replacing numeric constants with magic numbers unless it is something super-obvious like 1 or just something used in tests. It's not just about conveniently refactoring code…

dkanus commented on pull request dkanus/Avarice#13 2021-07-22 21:52:31 +03:00
Add network link to ue-server implementation

It is expected limit that we use as a capacity.

dkanus commented on pull request dkanus/Avarice#13 2021-07-22 21:41:39 +03:00
Add network link to ue-server implementation

Using clippy is a great suggestion, but the only warnings it produces regarding files in src/link/* are about dead-code. "unreal_config" code might be deleted (moved out into another project), so I…

dkanus commented on pull request dkanus/Avarice#13 2021-07-22 21:31:21 +03:00
Add network link to ue-server implementation

Agreed.

dkanus commented on pull request dkanus/Avarice#13 2021-07-22 21:27:40 +03:00
Add network link to ue-server implementation

Woa, that's neat. Agreed.

dkanus commented on pull request dkanus/Avarice#13 2021-07-22 21:21:35 +03:00
Add network link to ue-server implementation

Agreed

dkanus pushed to feature_link at dkanus/Avarice 2021-07-22 16:19:55 +03:00
bb1f73a755 Change character byte definitions into b'X' form
af3341c1e7 Refactor MessageReader for clarity
0dedd1d1f1 Change MessageReader to use with_capacity
b846fcf55b Fix MessageReader documentation
ba3ac088dd Refactor numeric constants for MessageReader
Compare 5 commits »
dkanus created pull request dkanus/Avarice#13 2021-07-21 08:51:40 +03:00
[WIP] Add MessageReader implementation