• Joined on 2020-07-03
dkanus commented on pull request dkanus/Avarice_old#13 2021-07-22 21:56:42 +03:00
Add network link to ue-server implementation

But upon further consideration I agree that there is no sense in defining this as a constant.

dkanus commented on pull request dkanus/Avarice_old#13 2021-07-22 21:55:52 +03:00
Add network link to ue-server implementation

In general I am against replacing numeric constants with magic numbers unless it is something super-obvious like 1 or just something used in tests. It's not just about conveniently refactoring code…

dkanus commented on pull request dkanus/Avarice_old#13 2021-07-22 21:52:31 +03:00
Add network link to ue-server implementation

It is expected limit that we use as a capacity.

dkanus commented on pull request dkanus/Avarice_old#13 2021-07-22 21:41:39 +03:00
Add network link to ue-server implementation

Using clippy is a great suggestion, but the only warnings it produces regarding files in src/link/* are about dead-code. "unreal_config" code might be deleted (moved out into another project), so I…

dkanus commented on pull request dkanus/Avarice_old#13 2021-07-22 21:31:21 +03:00
Add network link to ue-server implementation

Agreed.

dkanus commented on pull request dkanus/Avarice_old#13 2021-07-22 21:27:40 +03:00
Add network link to ue-server implementation

Woa, that's neat. Agreed.

dkanus commented on pull request dkanus/Avarice_old#13 2021-07-22 21:21:35 +03:00
Add network link to ue-server implementation

Agreed

dkanus pushed to feature_link at dkanus/Avarice_old 2021-07-22 16:19:55 +03:00
bb1f73a755 Change character byte definitions into b'X' form
af3341c1e7 Refactor MessageReader for clarity
0dedd1d1f1 Change MessageReader to use with_capacity
b846fcf55b Fix MessageReader documentation
ba3ac088dd Refactor numeric constants for MessageReader
Compare 5 commits »
dkanus created pull request dkanus/Avarice_old#13 2021-07-21 08:51:40 +03:00
[WIP] Add MessageReader implementation
dkanus pushed to feature_link at dkanus/Avarice_old 2021-07-20 23:52:45 +03:00
0a86852197 Add MessageReader implementation
dkanus commented on issue Ggg_123/Avarice#1 2021-07-17 10:43:29 +03:00
RFC: Сетевое взаимодействие между worker/supervisor

В приложении слегка обновленный файл с SRS.

Я не вижу смысла использовать что-то кроме tcp/ip, поэтому про udp (и…

dkanus pushed to master at dkanus/KFZedsReport 2021-06-13 23:49:53 +03:00
c8613dc519 first commit
dkanus created repository dkanus/KFZedsReport 2021-06-13 23:48:53 +03:00
dkanus commented on issue dkanus/Avarice_old#10 2020-12-02 13:00:56 +03:00
Refactor tests to remove test fixtures and serial crate

serial was removed as a dependency, tests were rewritten to use separate temporary files.

Unnecessary files are cleaned up with auxiliary struct with the drop trait, which seems to work just fine and does not require another dependency. Maybe just keep this solution or is tempfile superior in some way?

Do we really need to move test data into the code? I feel like separating them is a cleaner approach.

dkanus commented on issue dkanus/Avarice_old#6 2020-12-02 12:53:46 +03:00
Split and rebase commits into a nicer-looking history

Merge undone to allow for a code review.

dkanus commented on issue dkanus/Avarice_old#9 2020-12-02 12:52:47 +03:00
Review dependencies for unecessary features

It sounds reasonable, but maybe wait until we have release version ready? Compile times do not seem to be an issue yet (and are unlikely to be in a foreseeable future), so it can save us some fuss.

dkanus created pull request dkanus/Avarice_old#8 2020-12-02 09:34:36 +03:00
feature_database
dkanus created pull request dkanus/Avarice_old#8 2020-12-02 09:34:36 +03:00
feature_database
dkanus reopened issue dkanus/Avarice_old#1 2020-12-02 09:33:53 +03:00
Implement database
dkanus reopened issue dkanus/Avarice_old#1 2020-12-02 09:33:53 +03:00
Implement database