Browse Source

Fix `HashTable` iterator not being created

Messed up during converting code for `AssociativeArray`'s iterator by
not paying enough attention and using old class instead of `HashTable`.
pull/8/head
Anton Tarasenko 2 years ago
parent
commit
1a42354cd2
  1. 23
      sources/Data/Collections/HashTableIterator.uc

23
sources/Data/Collections/HashTableIterator.uc

@ -1,6 +1,6 @@
/** /**
* Iterator for iterating over `AssociativeArray`'s items. * Iterator for iterating over `HashTable`'s items.
* Copyright 2020 Anton Tarasenko * Copyright 2022 Anton Tarasenko
*------------------------------------------------------------------------------ *------------------------------------------------------------------------------
* This file is part of Acedia. * This file is part of Acedia.
* *
@ -21,8 +21,8 @@ class HashTableIterator extends Iter
dependson(HashTable); dependson(HashTable);
var private bool hasNotFinished; var private bool hasNotFinished;
var private AssociativeArray relevantCollection; var private HashTable relevantCollection;
var private AssociativeArray.Index currentIndex; var private HashTable.Index currentIndex;
var private bool skipNoneReferences; var private bool skipNoneReferences;
@ -34,17 +34,20 @@ protected function Finalizer()
public function bool Initialize(Collection relevantArray) public function bool Initialize(Collection relevantArray)
{ {
local AssociativeArray.Index emptyIndex; local AcediaObject currentKey;
local HashTable.Index emptyIndex;
currentIndex = emptyIndex; currentIndex = emptyIndex;
relevantCollection = AssociativeArray(relevantArray); relevantCollection = HashTable(relevantArray);
if (relevantCollection == none) { if (relevantCollection == none) {
return false; return false;
} }
hasNotFinished = (relevantCollection.GetLength() > 0); hasNotFinished = (relevantCollection.GetLength() > 0);
if (GetKey() == none) { currentKey = GetKey();
if (currentKey == none) {
relevantCollection.IncrementIndex(currentIndex); relevantCollection.IncrementIndex(currentIndex);
} }
_.memory.Free(currentKey);
return true; return true;
} }
@ -66,7 +69,7 @@ public function Iter Next(optional bool deprecated)
while (hasNotFinished) while (hasNotFinished)
{ {
hasNotFinished = relevantCollection.IncrementIndex(currentIndex); hasNotFinished = relevantCollection.IncrementIndex(currentIndex);
if (relevantCollection.GetEntryByIndex(currentIndex).value != none) { if (relevantCollection.IsSomethingByIndex(currentIndex)) {
return self; return self;
} }
} }
@ -75,12 +78,12 @@ public function Iter Next(optional bool deprecated)
public function AcediaObject Get() public function AcediaObject Get()
{ {
return relevantCollection.GetEntryByIndex(currentIndex).value; return relevantCollection.GetItemByIndex(currentIndex);
} }
public function AcediaObject GetKey() public function AcediaObject GetKey()
{ {
return relevantCollection.GetEntryByIndex(currentIndex).key; return relevantCollection.GetKeyByIndex(currentIndex);
} }
public function bool HasFinished() public function bool HasFinished()

Loading…
Cancel
Save