@ -1,4 +1,7 @@
/** /**
* Author: Anton Tarasenko
* Home repo: https://insultplayers.ru/git/AcediaFramework/AcediaCore/
* License: GPL
* Copyright 2023 Anton Tarasenko * Copyright 2023 Anton Tarasenko
*------------------------------------------------------------------------------ *------------------------------------------------------------------------------
* This file is part of Acedia. * This file is part of Acedia.
@ -18,35 +21,74 @@
*/ */
class MapTool extends AcediaObject; class MapTool extends AcediaObject;
//! Tool for adapting AcediaLauncher's map lists for [`xVotingHandler`].
//!
//! This class is responsible for making [`xVotingHandler`] use specific maps (defined in
//! AcediaLauncer's configs) for specific game modes.
//! To achieve that it abuses [`xVotingHandler`]'s ability to filter maps by
//! game mode-specific prefix.
//! Normally prefix filtering for [`xVotingHandler`] is of limited use, because most Killing Floor
//! maps start with the same prefix `KF-` (and some objective ones starting with `KFO-`).
//! However we swap that prefix for something unique for each game mode: `MapSet0-`, `MapSet1-`,
//! etc, allowing us to pick the precise map set we want.
//!
//! There's two main challenges:
//!
//! 1. *Altered map names break voting* - since [`xVotingHandler`] expects to be provided real map
//! names and our mangled ones. We deal with it by catching a map change message broadcasted
//! right before actual map change occurs and swap our names with real ones.
//! 2. *Increased amount of maps to replicate* - if we implement this name mangling by using
//! a naive approach, in which we separately add maps for every game mode, then it will lead to
//! drastic increase in replication time of the complete map list to players.
//! Consider, for example, that you have 10 different game modes with exactly the same maps:
//! we will be needlessly replicating the exact same thing 10 times!
//! To solve this issue we specifically track map lists other game modes use, along with
//! prefixes assigned to them, and reuse already added maps in case two game modes are defined
//! to use the exactly same ones.
/// For storing which map sequences have which prefixes. Storage order is important.
struct MapSequenceRecord {
var public array<string> sequence;
var public string prefix;
};
// To avoid doing excesive work when injecting maps for a second time
var private bool injectedMaps;
// Finding voting handler is not cheap, so only do it once and then store it. // Finding voting handler is not cheap, so only do it once and then store it.
var private NativeActorRef votingHandlerReference; var private NativeActorRef votingHandlerReference;
// Maps map pseudonims we've used in voting handler to real map names // Resulting full map list with pseudonim (with replaced prefixes) and real names of maps.
var private HashTable pseudonimToMap;
var private array<VotingHandler.MapVoteMapList> pseudonimMapList; var private array<VotingHandler.MapVoteMapList> pseudonimMapList;
var private array<VotingHandler.MapVoteMapList> realMapList; var private array<VotingHandler.MapVoteMapList> realMapList;
var private int gameModesSeen;
// Map sequences used by game modes we've seen so far.
var private array<MapSequenceRecord> usedMapSequences;
// To more easily detect broadcasted message about map change we replace it with our own that is
// both unlikely to occur and is easy to get voted map name from.
var private string backupMessageMapWon; var private string backupMessageMapWon;
var private string backupMessageAdminMapChange; var private string backupMessageAdminMapChange;
var private const string ACEDIA_MAP_FORCED_COMMAND; var private const string ACEDIA_ADMIN_ MAP_CHANG E_COMMAND;
var private const string ACEDIA_MAP_WON_COMMAND; var private const string ACEDIA_MAP_WON_COMMAND;
protected function Constructor() { var private LoggerAPI.Definition fatVotingHandlerMissing, warnMissingMapList;
pseudonimToMap = _.collections.EmptyHashTable();
}
protected function Finalizer() { protected function Finalizer() {
_server.unreal.broadcasts.OnHandleText(self).Disconnect(); _server.unreal.broadcasts.OnHandleText(self).Disconnect();
_.memory.Free(votingHandlerReference); _.memory.Free(votingHandlerReference);
_.memory.Free(pseudonimToMap);
votingHandlerReference = none; votingHandlerReference = none;
pseudonimToMap = none;
pseudonimMapList.length = 0; pseudonimMapList.length = 0;
realMapList.length = 0; realMapList.length = 0;
gameModesSeen = 0; usedMapSequences.length = 0;
injectedMaps = false;
} }
public function bool Initialize(NativeActorRef initVotingHandlerReference) { /// Initializes [`MapTool`] by associating it with an [`XVotingHandler`].
///
/// Initialization fails if [`initVotingHandlerReference`] doesn't provide reference to
/// [`XVotingHandler`] or caller [`MapTool`] already was initialized.
/// Returns `true` iff initialization was successful.
public final function bool Initialize(NativeActorRef initVotingHandlerReference) {
if (initVotingHandlerReference == none) return false; if (initVotingHandlerReference == none) return false;
if (XVotingHandler(initVotingHandlerReference.Get()) == none) return false; if (XVotingHandler(initVotingHandlerReference.Get()) == none) return false;
@ -55,47 +97,121 @@ public function bool Initialize(NativeActorRef initVotingHandlerReference) {
return true; return true;
} }
public function string LoadGameModeMaps(GameMode gameMode) { /// Adds map information from the new game mode.
local int i; ///
/// Returns prefix that given game mode must use to display maps configured for it.
public final function string AddGameMode(GameMode gameMode) {
local XVotingHandler votingHandler; local XVotingHandler votingHandler;
local string gameModePrefix;
votingHandler = GetVotingHandler();
if (votingHandler == none) {
_.logger.Auto(fatVotingHandlerMissing);
return "KF";
}
if (CheckNeedToLoadMaps(gameMode, gameModePrefix)) {
LoadGameModeMaps(gameMode, gameModePrefix, votingHandler);
}
return gameModePrefix;
}
/// Injects final map list into [`XVotingHandler`].
///
/// Call this after all game modes have been added.
/// Shouldn't be called more than once.
public final function Inject() {
local XVotingHandler votingHandler;
votingHandler = GetVotingHandler();
if (votingHandler == none) {
_.logger.Auto(fatVotingHandlerMissing);
return;
}
votingHandler.mapList = pseudonimMapList;
votingHandler.mapCount = pseudonimMapList.length;
// Replace map change messages with our commands and make sure it is done only once,
// in case we mess up somewhere else and call this method second time
if (!injectedMaps) {
backupMessageMapWon = votingHandler.lmsgMapWon;
backupMessageAdminMapChange = votingHandler.lmsgAdminMapChange;
votingHandler.lmsgMapWon = ACEDIA_MAP_WON_COMMAND $ "::%mapname%";
votingHandler.lmsgAdminMapChange = ACEDIA_ADMIN_MAP_CHANGE_COMMAND $ "::%mapname%";
_server.unreal.broadcasts.OnHandleText(self).connect = HandleMapChange;
}
injectedMaps = true;
}
/// Builds arrays of [`VotingHandler::MapVoteMapList`] (each such item describes a map +
/// its meta data in a way [`XVotingHandler`] understands).
private function string LoadGameModeMaps(
GameMode gameMode,
string gameModePrefix,
XVotingHandler votingHandler
) {
local int i;
local ArrayList gameModeMaps; local ArrayList gameModeMaps;
local Text mapNameReal, mapNamePseudonim; local Text mapNameReal, mapNamePseudonim;
local VotingHandler.MapHistoryInfo nextMapInfo; local VotingHandler.MapHistoryInfo nextMapInfo;
local VotingHandler.MapVoteMapList nextRecord; local VotingHandler.MapVoteMapList nextRecord;
local array<VotingHandler.MapVoteMapList> newMapsPseudonim, newMapReal; local array<VotingHandler.MapVoteMapList> newMapsPseudonim, newMapReal;
local string gameModePrefix;
votingHandler = GetVotingHandler();
if (votingHandler == none) {
return "!!!";
}
gameModePrefix = ("KF" $ gameModesSeen);
nextRecord.bEnabled = true; nextRecord.bEnabled = true;
gameModeMaps = GetAllGameModeMaps(gameMode); gameModeMaps = GetAllGameModeMaps(gameMode);
for (i = 0; i < gameModeMaps.GetLength(); i += 1) { for (i = 0; i < gameModeMaps.GetLength(); i += 1) {
// Make a pseudonim to map connection
mapNameReal = gameModeMaps.GetText(i); mapNameReal = gameModeMaps.GetText(i);
mapNamePseudonim = MakeMapPseudonim(mapNameReal, gameModePrefix); mapNamePseudonim = MakeMapPseudonim(mapNameReal, gameModePrefix);
pseudonimToMap.SetItem(mapNamePseudonim, mapNameReal);
// Setup `VotingHandler.MapVoteMapList` struct for next map
if (votingHandler.history != none) { if (votingHandler.history != none) {
nextMapInfo = votingHandler.history.GetMapHistory(mapNameReal.ToString()); nextMapInfo = votingHandler.history.GetMapHistory(mapNameReal.ToString());
nextRecord.playCount = nextMapInfo.p; nextRecord.playCount = nextMapInfo.p;
nextRecord.sequence = nextMapInfo.s; nextRecord.sequence = nextMapInfo.s;
} else {
nextRecord.playCount = 0;
nextRecord.sequence = 0;
} }
nextRecord.mapName = mapNamePseudonim.ToString(); nextRecord.mapName = _.text.IntoString(mapNamePseudonim);
newMapsPseudonim[newMapsPseudonim.length] = nextRecord; newMapsPseudonim[newMapsPseudonim.length] = nextRecord;
nextRecord.mapName = mapNameReal.ToString(); nextRecord.mapName = _.text.IntoString( mapNameReal);
newMapReal[newMapReal.length] = nextRecord; newMapReal[newMapReal.length] = nextRecord;
} }
AppendMaps(newMapsPseudonim, newMapReal); AppendMapsIntoVotingHandler (newMapsPseudonim, newMapReal);
gameModesSeen += 1; _.memory.Free(gameModeMaps) ;
return gameModePrefix; return gameModePrefix;
} }
private function bool CheckNeedToLoadMaps(GameMode gameMode, out string prefix) {
local int mapSequenceIndex, mapListIndex;
local bool sameMapList, foundMatch;
local array<string> existingMapSequence, newMapSequence;
local MapSequenceRecord newRecord;
// We don't need to load maps for the `gameMode` only when we've already added the exactly same
// map sequence, order being important
newMapSequence = gameMode.GetIncludedMapLists_S();
for (mapSequenceIndex = 0; mapSequenceIndex < usedMapSequences.length; mapSequenceIndex += 1) {
existingMapSequence = usedMapSequences[mapSequenceIndex].sequence;
if (existingMapSequence.length != newMapSequence.length) {
continue;
}
foundMatch = true;
for (mapListIndex = 0; mapListIndex < newMapSequence.length; mapListIndex += 1) {
// Map lists are ASCII config names, so we can compare them with case-ignoring
// built-in `~=` operator works (it can only handle properly ASCII input)
sameMapList = (existingMapSequence[mapListIndex] ~= newMapSequence[mapListIndex]);
if (!sameMapList) {
foundMatch = false;
break;
}
}
if (foundMatch) {
prefix = usedMapSequences[mapSequenceIndex].prefix;
return false;
}
}
newRecord.sequence = newMapSequence;
newRecord.prefix = "MapSet" $ usedMapSequences.length;
usedMapSequences[usedMapSequences.length] = newRecord;
prefix = newRecord.prefix;
return true;
}
// Replaces prefixes like "KF-", "KFO-" or "KFS-" with "{gameModePrefix}-".
private function Text MakeMapPseudonim(Text realName, string gameModePrefix) { private function Text MakeMapPseudonim(Text realName, string gameModePrefix) {
local Parser parser; local Parser parser;
local MutableText prefix, nameBody; local MutableText prefix, nameBody;
@ -124,26 +240,17 @@ private function ArrayList GetAllGameModeMaps(GameMode gameMode) {
local HashTable uniqueMapSet; local HashTable uniqueMapSet;
local ArrayList result; local ArrayList result;
local array<Text> usedMapLists; local array<Text> usedMapLists;
local MapList nextMapConfig;
local array<string> nextMapArray; local array<string> nextMapArray;
local Text nextMapName, lowerMapName; local Text nextMapName, lowerMapName;
uniqueMapSet = _.collections.EmptyHashTable(); // to quickly make sure we add each map only once uniqueMapSet = _.collections.EmptyHashTable(); // for testing map name uniqueness
result = _.collections.EmptyArrayList(); result = _.collections.EmptyArrayList();
usedMapLists = gameMode.GetIncludedMapLists(); usedMapLists = gameMode.GetIncludedMapLists();
for (i = 0; i < usedMapLists.length; i += 1) { for (i = 0; i < usedMapLists.length; i += 1) {
// Get maps from `MapList` config nextMapArray = GetMapNameFromConfig(usedMapLists[i]);
nextMapConfig = MapList(class'MapList'.static.GetConfigInstance(usedMapLists[i]));
nextMapArray.length = 0;
if (nextMapConfig != none) {
nextMapArray = nextMapConfig.map;
} else {
//_.logger.Auto(warnMissingMapList).Arg(usedMapLists[i].Copy());
}
_.memory.Free(nextMapConfig);
// Add maps we haven't yet added from other lists
for (j = 0; j < nextMapArray.length; j += 1) { for (j = 0; j < nextMapArray.length; j += 1) {
nextMapName = _.text.FromString(nextMapArray[j]); nextMapName = _.text.FromString(nextMapArray[j]);
// Use lower case version of map name for uniqueness testing to ignore characters' case
lowerMapName = nextMapName.LowerCopy(); lowerMapName = nextMapName.LowerCopy();
if (!uniqueMapSet.HasKey(lowerMapName)) { if (!uniqueMapSet.HasKey(lowerMapName)) {
uniqueMapSet.SetItem(lowerMapName, none); uniqueMapSet.SetItem(lowerMapName, none);
@ -158,7 +265,21 @@ private function ArrayList GetAllGameModeMaps(GameMode gameMode) {
return result; return result;
} }
private function AppendMaps( private function array<string> GetMapNameFromConfig(Text configName) {
local MapList mapConfig;
local array<string> result;
mapConfig = MapList(class'MapList'.static.GetConfigInstance(configName));
if (mapConfig == none) {
_.logger.Auto(warnMissingMapList).Arg(configName.Copy());
} else {
result = mapConfig.map;
_.memory.Free(mapConfig);
}
return result;
}
private function AppendMapsIntoVotingHandler(
array<VotingHandler.MapVoteMapList> newMapsPseudonim, array<VotingHandler.MapVoteMapList> newMapsPseudonim,
array<VotingHandler.MapVoteMapList> newMapsReal) { array<VotingHandler.MapVoteMapList> newMapsReal) {
local int i; local int i;
@ -166,7 +287,7 @@ private function AppendMaps(
votingHandler = GetVotingHandler(); votingHandler = GetVotingHandler();
if (votingHandler == none) { if (votingHandler == none) {
warn("votingHandler is none!" ); _.logger.Auto(fatVotingHandlerMissing );
return; return;
} }
for (i = 0; i < newMapsPseudonim.length; i += 1) { for (i = 0; i < newMapsPseudonim.length; i += 1) {
@ -177,21 +298,6 @@ private function AppendMaps(
} }
} }
public final function InjectMaps() {
local XVotingHandler votingHandler;
votingHandler = GetVotingHandler();
if (votingHandler != none) {
votingHandler.mapList = pseudonimMapList;
votingHandler.mapCount = pseudonimMapList.length;
backupMessageMapWon = votingHandler.lmsgMapWon;
backupMessageAdminMapChange = votingHandler.lmsgAdminMapChange;
votingHandler.lmsgMapWon = ACEDIA_MAP_WON_COMMAND $ "::%mapname%";
votingHandler.lmsgAdminMapChange = ACEDIA_MAP_FORCED_COMMAND $ "::%mapname%";
_server.unreal.broadcasts.OnHandleText(self).connect = HandleMapChange;
}
}
private function bool HandleMapChange( private function bool HandleMapChange(
Actor sender, Actor sender,
out string message, out string message,
@ -211,7 +317,7 @@ private function bool HandleMapChange(
if (parser.Ok()) { if (parser.Ok()) {
message = Repl(backupMessageMapWon, "%mapname%", parser.GetRemainderS()); message = Repl(backupMessageMapWon, "%mapname%", parser.GetRemainderS());
} else { } else {
parser.Match(P(ACEDIA_MAP_FOR CED _COMMAND)); parser.Match(P(ACEDIA_ADMIN_ MAP_CHANG E_COMMAND));
parser.Match(P("::")); parser.Match(P("::"));
if (parser.Ok()) { if (parser.Ok()) {
message = Repl(backupMessageAdminMapChange, "%mapname%", parser.GetRemainderS()); message = Repl(backupMessageAdminMapChange, "%mapname%", parser.GetRemainderS());
@ -233,6 +339,8 @@ private function XVotingHandler GetVotingHandler() {
} }
defaultproperties { defaultproperties {
ACEDIA_MAP_FOR CED _COMMAND = "ACEDIA_LAUNCHER:MAP_FOR CED :DEADBEEF" ACEDIA_ADMIN_ MAP_CHANG E_COMMAND = "ACEDIA_LAUNCHER:ADMIN_ MAP_CHANG E:DEADBEEF"
ACEDIA_MAP_WON_COMMAND = "ACEDIA_LAUNCHER:MAP_WON:DEADBEEF" ACEDIA_MAP_WON_COMMAND = "ACEDIA_LAUNCHER:MAP_WON:DEADBEEF"
fatVotingHandlerMissing = (l=LOG_Fatal,m="No voting `XVotingHandler` available. This is unexpected at this stage. Report this issue.")
warnMissingMapList = (l=LOG_Warning,m="Cannot find map list `%1`.")
} }
