Ggg_123
  • Joined on Nov 17, 2020
Repositories Public Activity Starred Repositories Following
1
 Followers
1

Ggg_123 commented on pull request dkanus/Avarice#13

Add network link to ue-server implementation

Suggestion: ``` --- a/src/link/message.rs +++ b/src/link/message.rs @@ -9,19 +9,22 @@ pub struct AvariceMessage { pub parameters: serde_json::Value, } -impl AvariceMessage { - ///…

3 years ago

Ggg_123 commented on pull request dkanus/Avarice#13

Add network link to ue-server implementation

Confusing name.

3 years ago

Ggg_123 commented on pull request dkanus/Avarice#13

Add network link to ue-server implementation

Why a method?

3 years ago

Ggg_123 commented on pull request dkanus/Avarice#13

Add network link to ue-server implementation

Confusing - you have push(add N bytes), push_byte(add 1 byte) and pop(get 1 ~~byte~~ message).

3 years ago

Ggg_123 commented on pull request dkanus/Avarice#13

Add network link to ue-server implementation

Writing `TcpStream` is sent - rewrite? No idea what that means.

3 years ago

Ggg_123 commented on pull request dkanus/Avarice#13

Add network link to ue-server implementation

// todo - add IP support, since 0.0.0.0 is subjective (make it default, but changeable)

3 years ago

Ggg_123 commented on pull request dkanus/Avarice#13

Add network link to ue-server implementation

Why is it a separate function, and not inside send/flush?

3 years ago

Ggg_123 commented on pull request dkanus/Avarice#13

Add network link to ue-server implementation

Why?

3 years ago

Ggg_123 commented on pull request dkanus/Avarice#13

Add network link to ue-server implementation

Missing else? Condition seems important.

3 years ago

Ggg_123 commented on pull request dkanus/Avarice#13

Add network link to ue-server implementation

Maybe remove continue?

3 years ago

Ggg_123 commented on pull request dkanus/Avarice#13

Add network link to ue-server implementation

Confusing name, since it's not related to https://doc.rust-lang.org/std/iter/trait.Iterator.html#tymethod.next, which is very common.

3 years ago

Ggg_123 commented on pull request dkanus/Avarice#13

Add network link to ue-server implementation

sent next message => sent this message?

3 years ago

Ggg_123 commented on pull request dkanus/Avarice#13

Add network link to ue-server implementation

warning: this import is redundant

3 years ago

Ggg_123 commented on pull request dkanus/Avarice#13

Add network link to ue-server implementation

Why "remove"?

3 years ago

Ggg_123 commented on pull request dkanus/Avarice#13

Add network link to ue-server implementation

Any explanation/doc on wtf is service/message_type/parameters?

3 years ago

Ggg_123 commented on pull request dkanus/Avarice#13

Add network link to ue-server implementation

Confusing name, since it's not related to https://doc.rust-lang.org/std/convert/trait.From.html#tymethod.from, which is very common.

3 years ago

Ggg_123 commented on pull request dkanus/Avarice#13

Add network link to ue-server implementation

Maybe expand s/t/p into words?

3 years ago

Ggg_123 commented on pull request dkanus/Avarice#13

Add network link to ue-server implementation

No newline at end of file

3 years ago

Ggg_123 pushed to feature_link at dkanus/Avarice

3 years ago

Ggg_123 commented on pull request dkanus/Avarice#13

Add network link to ue-server implementation

Elaborate => "Conversion happens in two steps"?

3 years ago